feat: WIP Kitty Graphics - #1148
Conversation
- Set up pipeline to dispatch APC sequences - (regression) - broke apc_c0_st_terminated and apc_empty tests
|
Very cool! I think we can maybe try to get in a minimal functional state. Then we can improve in this PR. Would you mind if add commits to this PR? @Atan-D-RP4 |
|
Also, are you on rio discord? so i can ping you there as well any case |
Please do. It's exactly why I made it a draft PR. The code changes here are terrible should not be in a release or even dev branch.
I am. I'm the same guy who prompted the merge for handling of APC's from you back in the middle of... April I think. My '@' is CanopyRaven. |
🙏 could you give me access to your fork, so i can push straight to it |
Nice will ping you there later |
You should have it now. Added you as collaborator. |
|
Nice thank you!! |
Tracking issue #940
The first stage of building up support for kitty's image protocol.
This updates the parser to extract parameters from the APC's and dispatch to an appropriate handler. Basically the pipeline.
Supporting the full protocol requires maintaining a bunch of state and having access to the some the renderer's state. I don't know how to work with the sugarloaf renderer, so direction on that would be appreciated.
Review of the existing changes is also necessary. The current way I'm doing the passthrough is ugly.