Build detail page fixes #492
Conversation
- Add field labels - Condense commit/type/PR fields - Fixes #46, make date and length field update as the build progresses
Also adds a "Wrap output" checkbox to the detail view.
This fixes all leftover display issues on mobile
| {% blocktrans %} | ||
| Due to the age of this build, the output of this build is no longer available. | ||
| {% endblocktrans %} |
There was a problem hiding this comment.
💯 -- I'm happy we are not supporting this anymore 👍🏼
There was a problem hiding this comment.
Yeah, I always figured we just drop it, I doubt anyone is looking at 8 year old builds.
| // Always update date and length, as these should update as the build progresses | ||
| this.date.valueHasMutated(); | ||
| this.length.valueHasMutated(); |
There was a problem hiding this comment.
Interesting. It's the first time I see .valueHasMutated(). I quickly tried to find the documentation for it but I wasn't able to 🤷🏼
I understand that we tell Knockout here that the value that comes from the API is automatically re-calculated internally in the object, right?
There was a problem hiding this comment.
Yeah, official documentation is light on this I believe. What this does is force KO to think the value changed and most importantly, it causes updates to all observables depending on this value changing.
This is needed because date_display is calculated off of date, but if there is no change to date, there would normally be no update to date_display.
Changes
New elements in the detail view
Updating times and actually showing a duration, and wrapping
Screencast.from.2024-09-20.18-27-29.webm
And viewing on mobile actually works now, it's very broken in production
Screencast.from.2024-09-20.18-31-13.webm