-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Open
Labels
AcceptedAccepted issue on our roadmapAccepted issue on our roadmapImprovementMinor improvement to codeMinor improvement to code
Milestone
Description
A few notes to come back to for tuning on this pattern:
- Turn the prevalidate form into a mixin, so that the base form can be
forms.Form
orforms.ModelForm
without struggling with any conflicts. Maybe this isn't necessary. -
is_disabled
should referenceself.errors
I think. This would populate the prevalidation errors ifform.errors
wasn't called first. The use case here is when displaying the form, we might use<form {% if form.is_disabled %}inert{% endif %}>
before we actually call{{ form | crispy }}
. The crispy filter callsform.errors
which populates all the validation errors. - Project: create forms are still usable by keyboard when disabled ext-theme#279 -- a few options here are
<form inert>
, disabling all of the fields in the Form class, or wrapping with.ui.disabled.segment
instead. There is no.ui.disabled.form
unfortunately. - Revisit disabling forms pattern in Add Pull Request builds page to settings #10656 and related PR
Metadata
Metadata
Assignees
Labels
AcceptedAccepted issue on our roadmapAccepted issue on our roadmapImprovementMinor improvement to codeMinor improvement to code
Type
Projects
Status
Planned