@remotion/renderer
: Allow scale factors leading to uneven dimensions
#5529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering videos with H264/H265 codecs, Remotion previously threw errors if scaling resulted in odd dimensions. This was particularly problematic when using scale factors that produced dimensions like 1400x907 (where 907 is odd).
This PR makes the validation more lenient by automatically rounding down odd dimensions to the nearest even number instead of throwing an error.
Changes
validateEvenDimensionsWithCodec
: Instead of throwing errors for odd dimensions, the function now rounds down to the nearest even numberExample
Before this change:
After this change:
Testing
Fixes #5528.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.