@remotion/lambda-php: Fix PHP 8.2 dynamic property deprecation for storageClass #5555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the PHP 8.2+ deprecation warning:
The issue occurred because the
$storageClass
property was being used throughout theRenderParams
class (constructor assignment, getter/setter methods, serialization) but was never properly declared as a class property. In PHP 8.2+, creating dynamic properties triggers a deprecation warning.Changes Made
protected $storageClass = null;
property declaration to theRenderParams
classRenderParamsStorageClassTest.php
to verify the fix and prevent regressionBefore
After
Verification
All tests pass without deprecation warnings:
This is a minimal, surgical fix that maintains full backward compatibility while resolving PHP 8.2+ compatibility issues.
Fixes #5542.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.