Skip to content

fix(create-video): Add macOS GitHub Actions path to git-status test #5559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

scotthavird
Copy link
Contributor

@scotthavird scotthavird commented Aug 5, 2025

🐛 Bug Fix

Fixes the failing create-video test in GitHub Actions on macOS runners.
mac-latest recent update to mac-15

📋 Problem

The git-status.test.ts test was failing in GitHub Actions after the migration from macos-13 to macos-14 runners. The test checks if the git repository location matches expected paths, but was missing the explicit GitHub Actions macOS path.

Error:

error: expect(received).toEqual(expected)
Expected: true
Received: false

🔍 Root Cause

  • GitHub Actions recently migrated from macos-13 to macos-14 runners (commit f2465c25bc)
  • The test had hardcoded path conditions for Windows (D:/a/remotion/remotion) but not for macOS GitHub Actions
  • The path resolution logic should work but apparently has subtle differences on macos-14 runners

🛠️ Solution

Added the explicit GitHub Actions macOS path (/Users/runner/work/remotion/remotion) to the test conditions:

status.location === 'D:/a/remotion/remotion' ||
status.location === '/Users/runner/work/remotion/remotion'  // ← Added this line

✅ Testing

  • Test passes locally with the fix
  • Verified this follows the same pattern as previous Windows path fix (commit 5625f951e7)
  • Maintains backwards compatibility with existing path resolution logic

📚 Context

This test has a history of needing platform-specific path fixes:

  • Jan 2023: Fixed for Windows with path normalization
  • May 2023: Added Windows GitHub Actions path (D:/a/remotion/remotion)
  • Now: Adding macOS GitHub Actions path

Follows the same approach as commit 5625f951e7 which added Windows GitHub Actions support.

The test was failing on macOS GitHub Actions runners after migrating
from macos-13 to macos-14 runners. This adds the explicit GitHub Actions
macOS path '/Users/runner/work/remotion/remotion' to the test conditions
to ensure compatibility across all CI environments.

Fixes the failing test in GitHub Actions while maintaining backwards
compatibility with existing path resolution logic.
Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 2:27am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 2:27am

Using macos-latest ensures the CI always runs on the most current
macOS runner without requiring manual updates. This provides:
- Automatic updates to latest macOS versions
- Better performance and up-to-date tooling
- Consistent behavior with other 'latest' runners

- Updates .github/workflows/push.yml to use macos-latest
- Aligns with the test fix for macOS GitHub Actions paths
@JonnyBurger
Copy link
Member

Oh nice!
I was wondering about this, thanks for sending this! 😊 All green on the first attempt! 🤩

@JonnyBurger JonnyBurger merged commit d7c211f into remotion-dev:main Aug 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants