Skip to content

Recorder: Replace deprecated startFrom/endAt with trimBefore/trimAfter + consistent formatting #5576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 10, 2025

This PR updates the template-recorder package to use the new trimBefore and trimAfter props instead of the deprecated startFrom and endAt props when working with video components.

The Remotion core library has renamed these props:

  • startFromtrimBefore
  • endAttrimAfter

Changes Made

Updated three key files to use the new prop names:

remotion/scenes/VideoScene/Webcam.tsx:

  • Changed component prop type from endAt: number | undefined to trimAfter: number | undefined
  • Updated VideoWithBlur component usage from startFrom={startFrame} endAt={endAt} to trimBefore={startFrame} trimAfter={trimAfter}

remotion/scenes/VideoScene/Display.tsx:

  • Changed component prop type from endAt: number | undefined to trimAfter: number | undefined
  • Updated OffthreadVideo component usage from startFrom={startFrame} endAt={endAt} to trimBefore={startFrame} trimAfter={trimAfter}

remotion/scenes/VideoScene/VideoScene.tsx:

  • Renamed local variable from endAt to trimAfter
  • Updated prop passing to child components to use the new trimAfter prop name

The functionality remains exactly the same - this is purely a prop name migration to use the current Remotion API and avoid deprecated warnings.

Fixes #5575.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel vercel bot temporarily deployed to Preview – remotion August 10, 2025 18:34 Inactive
Copy link

vercel bot commented Aug 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
bugs Ready Preview Comment Aug 13, 2025 6:31am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
remotion ⬜️ Skipped Aug 13, 2025 6:31am

@vercel vercel bot temporarily deployed to Preview – remotion August 10, 2025 18:40 Inactive
@Copilot Copilot AI changed the title [WIP] startFrom and endAt should be renamed in template-recorder template-recorder: Replace deprecated startFrom/endAt with trimBefore/trimAfter Aug 10, 2025
@Copilot Copilot AI requested a review from JonnyBurger August 10, 2025 18:42
Copilot finished work on behalf of JonnyBurger August 10, 2025 18:42
@vercel vercel bot temporarily deployed to Preview – remotion August 13, 2025 06:29 Inactive
@vercel vercel bot temporarily deployed to Preview – remotion August 13, 2025 06:30 Inactive
@JonnyBurger JonnyBurger changed the title template-recorder: Replace deprecated startFrom/endAt with trimBefore/trimAfter Recorder: Replace deprecated startFrom/endAt with trimBefore/trimAfter + consistent formatting Aug 13, 2025
@JonnyBurger JonnyBurger marked this pull request as ready for review August 13, 2025 06:31
@JonnyBurger JonnyBurger merged commit 8f3fcf6 into main Aug 13, 2025
11 of 13 checks passed
@JonnyBurger JonnyBurger deleted the copilot/fix-5575 branch August 13, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

startFrom and endAt should be renamed in template-recorder
2 participants