Unpin rviz version and update to Ubuntu Resolute for rolling#6262
Merged
Conversation
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Temporarily comment this out Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Pin ros2/rviz to version 2cbba6bbeb32 to avoid Qt5 and Qt6 mismatch. Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Collaborator
Author
|
Rolling has been updated to Ubuntu 26.04 last week, it's probably time to unpin rviz version so that we can get our images updated: https://hub.docker.com/_/ros/ |
mini-1235
commented
Jul 13, 2026
| type: git | ||
| url: https://github.com/BehaviorTree/BehaviorTree.CPP.git | ||
| version: 7119df95a17086f55e3690cf8d7b7663b59319d0 | ||
| url: https://github.com/mini-1235/BehaviorTree.CPP.git |
Collaborator
Author
There was a problem hiding this comment.
Maybe we should wait for this to be merged instead of using my fork: BehaviorTree/BehaviorTree.CPP#1163
8 tasks
Collaborator
Author
|
I have a ref job that proves this PR is building correctly: https://github.com/mini-1235/navigation2/actions/runs/29241844155/job/86789500543 |
Member
|
LGTM, I'd prefer the BT.CPP update made on its main branch before merging, but if its not this week I;ll merge this anyway. Can we get the build turning over though in our CI? Maybe we just need to bump the cache version (which may be good regardless given the massive upgrade changes to be made here). |
SteveMacenski
approved these changes
Jul 13, 2026
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Collaborator
Author
|
I tried to bump the cache key but it doesn't work. If I remember correctly this is because a conflict between the base image and circleci, the CI will turn green again after the base image is updated (when this PR is merged) |
Updated repository URL and version for BehaviorTree.CPP. Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Contributor
Merge Queue Status
This pull request spent 23 seconds in the queue, including 3 seconds running CI. Required conditions to merge
ReasonPull request #6262 has been dequeued GitHub refused to merge the pull request. You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information. This is usually enforced by a branch protection or ruleset rule. HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Tick the box to put this pull request back in the merge queue (same as
|
Collaborator
Author
The errors are related to the base image still on 24.04, I will go ahead and merge this so that I can get the base image updated to 26.04 Hmm looks like I don't have permission to merge here, I will wait for you to merge it |
2 tasks
Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
Member
|
@mini-1235 check on the image and so forth |
Member
|
https://github.com/ros-navigation/nav2_docker/actions/runs/29440765748 triggering the docker build |
Member
|
https://github.com/ros-navigation/nav2_docker/actions/runs/29440765748/job/87438839657 failing on the ament index cpp |
Collaborator
Author
|
That will be resolved after #6136 is merged, I believe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.