Skip to content

Link ANTLR4 Miniscript grammar#1007

Open
Nuhiat-Arefin wants to merge 1 commit into
rust-bitcoin:masterfrom
Nuhiat-Arefin:docs/antlr4-miniscript-grammar
Open

Link ANTLR4 Miniscript grammar#1007
Nuhiat-Arefin wants to merge 1 commit into
rust-bitcoin:masterfrom
Nuhiat-Arefin:docs/antlr4-miniscript-grammar

Conversation

@Nuhiat-Arefin

Copy link
Copy Markdown

Adds a README link to the ANTLR4 grammar for Miniscript expressions in the antlr/grammars-v4 repository.

Assisted-by: OpenAI GPT-5

@satsfy satsfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept NACK

From my point of view, this doesn't add value for rust-miniscript users. It reads as promotion for the author's own grammar. The grammar also only covers surface syntax with the type system out of scope, so it's of limited use for real tooling anyway. If anything, it should not be occupying space on the project's main README.md because this has not been a need of rust-miniscript users up until now.

ANTLR also does not support Rust targets. Any use-case I can think of is built on top of rust-miniscript, not within it.

Could you provide some stronger justification for including this antlr grammar?

@trevarj

trevarj commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Concept NACK from me as well.

We aren't using ANTLR4 for parser generation (or any parser/lexer generator), so I don't really see the correlation.

@apoelstra

Copy link
Copy Markdown
Member

I'm gonna say concept ACK.

It's true that this has nothing to do with rust-miniscript, the Rust library. But this library is also the central hub for Miniscript research in general, since the other main implementation is built into Core and not designed to be so extensible.

@apoelstra

Copy link
Copy Markdown
Member

We may want to move this eventually to an "other resources" section. And I guess we ought to link Dmitry's Alloy implementation too, which actually found some bugs here.

@apoelstra

Copy link
Copy Markdown
Member

@Nuhiat-Arefin can you add an "Other Resources" section, above "Release Notes", and add this there instead of near the top of the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants