feat: filter for ping events

[infiniteregrets]

Important

Adds ping event handling and timeout detection in Stream.readStream() to ensure connection health.

• Behavior:
  • Adds ping event handling in Stream.readStream() to update lastPingTime on 'ping' events.
  • Introduces PING_TIMEOUT_MS constant and checkPingTimeout function to detect ping timeouts.
  • Throws error if no ping received for over 30 seconds.
• Error Handling:
  • Clears pingInterval on stream closure or error in Stream.readStream().
  • Throws pingTimeoutError if detected during stream processing.
• Misc:
  • Adds pingInterval to periodically check for ping timeouts in Stream.readStream().

^{This description was created by for 648f827. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 648f827 in 2 minutes and 27 seconds

More details

• Looked at 91 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. src/index.extras.ts:454

• Draft comment:
  Reset pingTimeoutError on receiving a ping to clear previous timeout state.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  This comment is purely informative, explaining what a piece of code does. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue.

2. src/index.extras.ts:71

• Draft comment:
  Typo detected in the S2ClientConfig type definition: 'appedRetryPolicy' should likely be renamed to 'appendRetryPolicy' for clarity and consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. src/index.extras.ts:135

• Draft comment:
  Typographical error in the S2Account class: the property 'accountURLSuffx' should be corrected to 'accountURLSuffix' for improved readability.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. src/index.extras.ts:239

• Draft comment:
  Typographical error in the S2Basin class: the property 'basinURLSuffx' should likely be renamed to 'basinURLSuffix' for consistency and clarity.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_aufrX3Waux95n4Wz

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

When handling a 'ping' event, reset the timeout error. Consider adding pingTimeoutError = null; after updating lastPingTime to clear any previous error.

Suggested change

	lastPingTime = Date.now();
	lastPingTime = Date.now(); pingTimeoutError = null;

[shikhar]

I think it should just be lastMessageTime (so also reset it on data). And timeout can be 20s to be consistent with other SDKs.

[shikhar]

This could be set much more accurately rather than waking up every second