Skip to content

Don't add same message twice on unsubscribe view #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

saadmk11
Copy link
Owner

@saadmk11 saadmk11 commented Feb 4, 2021

Do not add the same message twice through the Django messages framework.

The message was already being added through SubscriptionAjaxResponseMixin

messages.error(self.request, self.message)

This caused a bug that would show that same message multiple times in the template.

@saadmk11 saadmk11 added the bug Something isn't working label Feb 4, 2021
@saadmk11 saadmk11 self-assigned this Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #25 (957bf9c) into master (c358499) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          395       393    -2     
  Branches        19        19           
=========================================
- Hits           395       393    -2     
Impacted Files Coverage Δ
newsfeed/views.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c358499...957bf9c. Read the comment docs.

@saadmk11 saadmk11 merged commit 9946ba3 into master Feb 4, 2021
@saadmk11 saadmk11 deleted the message-bug branch February 4, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant