Replace awk -F based csv iteration by IFS + built-in for loop
#175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`awk -F,` splits values by comma but built-in for loop reinterpret each values. This behavior does not allow us to contain internal field separator (such as whitespace) in DB_EXTENSION for example. By setting environment variable `IFS` we can control internal field separator that will affect to for-in loop.
Closed
See pull request #11 * Fix IFS parsing (Re4zOon) * remove empty line (Re4zOon) * Make temporary variable `IFS_ORG` function-local (kkimurak) Co-authored-by: Re4zOon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awk -F,splits values by comma but built-in for loop reinterpret each values. This behavior does not allow us to contain internal field separator (such as whitespace) in DB_EXTENSION for example.By setting environment variable
IFSwe can control internal field separator that will affect to for-in loop. This PR replaceawk -F,based word splitting by settingIFSthen for-in loop.This change allow us to include additional options to each element in
DB_EXTENSIONS- for example--env 'DB_EXTENSION=extension_name CASCADE(CASCADEis an option to load extensions required by specified extension).See full syntax in https://www.postgresql.org/docs/current/sql-createextension.html .
note: This PR is ported from my fork kkimurak#9, included in releases 20250717 and later and is available for testing.