Skip to content

Refactor ControlCards to use dataclass for deterministic deck order #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samuelduchesne
Copy link
Owner

Summary

  • convert ControlCards to a dataclass with ordered fields and default END
  • iterate over dataclass fields when generating deck output
  • add regression test ensuring ControlCards deck output is stable across runs
  • handle missing graph nodes when resolving TypeVariable predecessors to avoid NetworkX errors
  • add regression test confirming Deck saving succeeds with absent graph nodes

Testing

  • pytest tests/test_controlcards_order.py tests/test_typevariable_predecessor.py tests/test_xml.py::TestDeck::test_save -q

https://chatgpt.com/codex/tasks/task_b_68a06d6a6620832bba02d65ece856d5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant