[do not merge] Add capture checking annotation to Scala 3 Standard Library #23688
+447
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natsukagami
changed the title
We previously had the `ex.label eq label` comparision, which is no longer the case, with the (package) private label field.
Mostly imports here
…tuple match types Currently it's tripping up the cc phase
Just imports for now, no quotes support for capturing types yet
We need to split the files here, because... ?
Relies on scala#23695 to land on next base version
natsukagami
force-pushed
the
cc-no-emit
branch
from
9ff8e6c to
13a2ea4
Compare
hamzaremmal
reviewed
Aug 14, 2025
There was a problem hiding this comment.
@natsukagami can we please drop this file?
bracevac
requested changes
Aug 14, 2025
hamzaremmal
reviewed
Aug 14, 2025
| @@ -1149,6 +1149,7 @@ class Definitions { | |||
| "reactor.util.annotation.NonNullApi" :: | |||
| "io.reactivex.annotations.NonNull" :: Nil) | |||
|
|
|||
|
|
|||
Linyxus
reviewed
Aug 14, 2025
There was a problem hiding this comment.
This file seems to be accidentally included in the PR too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
boundaryis now capture-checked, preventingLabelfrom being leaked outside of its correspondingboundary. Requires Makecaps.Capabilitynon-experimental #23507.Files missing capture checking
Tuple.scala, waiting for Fix match type bounds checking problem #23695 to reach the next base versionMirror.scala, which requires auto-generated Mirrors to be compatible with extending one of thecaps.Capabilitysubtraits. Currently the plan is to simply ban case classes.