Skip to content

fix: generate an array view when an Array C++ type is requested#2335

Merged
ianna merged 1 commit into
mainfrom
ianna/cppyy-awkward-git-bugfix
Mar 22, 2023
Merged

fix: generate an array view when an Array C++ type is requested#2335
ianna merged 1 commit into
mainfrom
ianna/cppyy-awkward-git-bugfix

Conversation

@ianna

@ianna ianna commented Mar 22, 2023

Copy link
Copy Markdown
Member

No description provided.

@ianna
ianna requested a review from jpivarski March 22, 2023 16:15
@ianna
ianna temporarily deployed to docs-preview March 22, 2023 16:27 — with GitHub Actions Inactive
@codecov

codecov Bot commented Mar 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2335 (3d15759) into main (a9dd20a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/highlevel.py 75.79% <0.00%> (-0.25%) ⬇️

@jpivarski jpivarski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was pulled out of #2334 because we should let the docs PR wait until cppyy 3.0.1 is released and we want the bug-fix (separate from docs) to go in as soon as possible.

@ianna, has this passed local tests (with cppyy 3.0.1 installed on your comptuer)? If so, we can merge it. The strictness of actually testing it in CI will come when cppyy 3.0.1 is on PyPI.

@ianna

ianna commented Mar 22, 2023

Copy link
Copy Markdown
Member Author

This was pulled out of #2334 because we should let the docs PR wait until cppyy 3.0.1 is released and we want the bug-fix (separate from docs) to go in as soon as possible.

@ianna, has this passed local tests (with cppyy 3.0.1 installed on your comptuer)? If so, we can merge it. The strictness of actually testing it in CI will come when cppyy 3.0.1 is on PyPI.

Yes, it does pass local tests.

@ianna
ianna merged commit 8296580 into main Mar 22, 2023
@ianna
ianna deleted the ianna/cppyy-awkward-git-bugfix branch March 22, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants