feat: add ak_to_feather and ak_from_feather functions#2683
Conversation
|
Hi! |
Codecov Report
Additional details and impacted files
|
|
When you're ready (when the docstrings are done and you've done "Update branch" with no errors), do "Ready for review" and assign me as the reviewer. |
|
Oh, I just remembered something: we want the new functions to show up in the documentation, too. They need to be added to the right sections of docs/reference/toctree.txt, and then they'll show up when you press the "View deployment" button, followed by "API reference", in the left side-bar. |
jpivarski
left a comment
There was a problem hiding this comment.
Nice! Just a few twisted changes, mostly described below.
Did you see the generated documentation? In the last "View Deployment" button, the documentation for the two functions are rendered at
and
| compression_level=None, | ||
| chunksize=None, | ||
| feather_version=2, | ||
| version=2, |
There was a problem hiding this comment.
I think it's good for this to be called feather_version, since it would be ambiguous what the "version" is referring to otherwise.
jpivarski
left a comment
There was a problem hiding this comment.
Great, thanks! I just made a few small changes before merging because they'd be easier to apply than to describe.
I'll give you a chance to make counter-edits, but I think this is ready to squash-and-merge.
|
@all-contributors please add @zbilodea for code |
|
I've put up a pull request to add @zbilodea! 🎉 |
No description provided.