feat: export more of typetracer#2816
Merged
Merged
Conversation
jpivarski
approved these changes
Nov 13, 2023
jpivarski
left a comment
jpivarski
left a comment
Member
There was a problem hiding this comment.
Great! It's ready to merge.
agoose77
enabled auto-merge (squash)
November 14, 2023 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
dask-awkwardis stabilising, it's clear that we need to export some more of our internals. In this PR, I add a constructor for unknown scalars, but not for arrays. This is a very restrictive approach, but I think we want to keep things as locked down as possible until we have a clearer sense of what's needed besides unknown scalars.