fix: include header-only files in sdist#2909
Merged
Merged
Conversation
We will need to pull in hatch from schemastore for full validation
jpivarski
approved these changes
Dec 20, 2023
jpivarski
left a comment
jpivarski
left a comment
Member
There was a problem hiding this comment.
Okay, good—this is another way to get header-only code, though I would think that users ordinarily wouldn't get it in a Python package; they'd use the CMakeLists fetch or explicitly download it...
Nope: the motivation for this is to make it possible to compile from the sdist. Full steam ahead!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2897 by ensuring that our SDist includes the header-only files. This is necessary both because semantically the SDist should represent a snapshot of the repo (in our case a generated snapshot), and because it's possible to build wheels from SDists, which is not possible if files are missing.