test: new cuda kernels#2922
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files |
ManasviGoyal
force-pushed
the
ManasviGoyal/tests-for-cuda-kernels
branch
from
January 15, 2024 09:23
62600e2 to
e64497c
Compare
ManasviGoyal
force-pushed
the
ManasviGoyal/tests-for-cuda-kernels
branch
from
February 2, 2024 19:52
e64497c to
a3c59e7
Compare
ManasviGoyal
force-pushed
the
ManasviGoyal/tests-for-cuda-kernels
branch
from
February 26, 2024 08:11
a3c59e7 to
f668fc5
Compare
ManasviGoyal
force-pushed
the
ManasviGoyal/tests-for-cuda-kernels
branch
2 times, most recently
from
March 21, 2024 08:23
0ff16ae to
a175ff4
Compare
ManasviGoyal
force-pushed
the
ManasviGoyal/tests-for-cuda-kernels
branch
from
March 21, 2024 10:30
a175ff4 to
bf9e269
Compare
ManasviGoyal
marked this pull request as ready for review
March 28, 2024 10:46
jpivarski
approved these changes
Mar 28, 2024
jpivarski
left a comment
Member
There was a problem hiding this comment.
It's great to have all these tests, which indicate which high-level functions are working now and ensure that they won't stop working as long as we run tests on a computer with a GPU.
I ran the tests on my GPU:
tests-cuda/test_1276_cuda_num.py ......... [ 5%]
tests-cuda/test_1276_cuda_transfers.py ............... [ 14%]
. [ 14%]
tests-cuda/test_1276_cupy_interop.py . [ 15%]
tests-cuda/test_1276_from_cupy.py ..... [ 18%]
tests-cuda/test_1300_same_for_numba_cuda.py .......... [ 24%]
............. [ 31%]
tests-cuda/test_1381_check_errors.py . [ 32%]
tests-cuda/test_1809_array_cuda_jit.py .............. [ 40%]
tests-cuda/test_2922a_new_cuda_kernels.py ............ [ 47%]
...................................................... [ 79%]
.... [ 82%]
tests-cuda/test_2922b_new_cuda_kernels.py ............ [ 89%]
.................. [100%]
==================== 169 passed in 9.44s =====================
So this is ready to merge! Since I know you won't be adding anything more today, I'll merge it. Any more tests should go into a new PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.