feat: add variable length loop kernels#3003
Conversation
1702eb5 to
2dadbc8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
6b477cb to
7f03b32
Compare
6b8e4eb to
843463f
Compare
|
@jpivarski there are a few more kernels that would fall in the same category but I think it would be better to do that in a new PR. |
jpivarski
left a comment
There was a problem hiding this comment.
Looks great! I also checked it out and tested it on my GPU. It's nice to see only 2 xfails left in tests-cuda.
Feel free to merge at any time.
Also, you're right to break them up in separate PRs like this.
Added the following kernels:
*variable-length inner loop (need to look for a way to optimize, added them to #2987)
Also, fixed awkward_ListArray_compact_offsets. Now we can generate tests for kernels where out arguments are also in arguments.