Skip to content

feat: add __dask_tokenize__ hook#3017

Merged
jpivarski merged 4 commits into
scikit-hep:mainfrom
lgray:patch-5
Mar 21, 2024
Merged

feat: add __dask_tokenize__ hook#3017
jpivarski merged 4 commits into
scikit-hep:mainfrom
lgray:patch-5

Conversation

@lgray

@lgray lgray commented Feb 11, 2024

Copy link
Copy Markdown
Collaborator

This is related to dask/dask#10918

In particular with dask/dask#10883 even those changes don't fix everything.

This at least makes it so that only shape is touched in the present error and with future changes.

This rest is that array.layout.form touches shape.

@codecov-commenter

codecov-commenter commented Feb 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.93%. Comparing base (b749e49) to head (1e7c09b).
Report is 36 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
src/awkward/highlevel.py 76.59% <50.00%> (-0.08%) ⬇️

... and 4 files with indirect coverage changes

Comment thread src/awkward/highlevel.py Outdated
@lgray

lgray commented Feb 12, 2024

Copy link
Copy Markdown
Collaborator Author

Just to link to the wider discussion: dask-contrib/dask-awkward#468

@agoose77

Copy link
Copy Markdown
Collaborator

@lgray is this still a direction worth pursuing?

@lgray

lgray commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator Author

Yes it is still useful in case people are sticking awkward arrays directly in the graph.

@agoose77

Copy link
Copy Markdown
Collaborator

Then I think we can merge this. Are there any tests in dask-awkward?

@lgray

lgray commented Feb 22, 2024

Copy link
Copy Markdown
Collaborator Author

Since the operation I mentioned is something you do outside of dask awkward there are no tests in dask awkward for it.

@agoose77

Copy link
Copy Markdown
Collaborator

@lgray hmm, fair. We can add tests here to check this, then :) Leave it to me ...

@jpivarski

Copy link
Copy Markdown
Member

This was accepted, but somehow missed getting merged. I'll merge it now.

@jpivarski
jpivarski merged commit f2e777f into scikit-hep:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants