fix: Support structured arrays in option type to_numpy#3060
Merged
Conversation
zonca
changed the title
zonca
force-pushed
the
to_numpy_option_record_array
branch
3 times, most recently
from
March 22, 2024 07:05
bce6167 to
f651e9a
Compare
zonca
changed the title
zonca
force-pushed
the
to_numpy_option_record_array
branch
2 times, most recently
from
March 22, 2024 07:13
e1ef8ac to
3754ede
Compare
Collaborator
|
@zonca Instead of adding the test to an existing test file, you should add a new test according to the contributing guidelines. |
zonca
force-pushed
the
to_numpy_option_record_array
branch
2 times, most recently
from
March 25, 2024 16:36
903284c to
66c491a
Compare
Factored the functionality of creating missing data in separate function, call it for each field in a structured array. Closes #3056
zonca
force-pushed
the
to_numpy_option_record_array
branch
from
March 25, 2024 16:38
66c491a to
db39ce1
Compare
Collaborator
Author
Thanks @ManasviGoyal, fixed that |
jpivarski
approved these changes
Mar 25, 2024
jpivarski
left a comment
jpivarski
left a comment
Member
There was a problem hiding this comment.
That does it, thank you! Since this appears to be a complete solution, with test, and I don't think you're adding any more to it, I'm going to merge it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_numpyon option-type of record typeSee #3056