fix: skip failing test when jax is not installed#3112
Merged
Conversation
ianna
commented
May 13, 2024
ianna
left a comment
ianna
left a comment
Member
Author
There was a problem hiding this comment.
@jpivarski - the test checked only if numba is present, but not jax.
jpivarski
approved these changes
May 13, 2024
jpivarski
left a comment
jpivarski
left a comment
Member
There was a problem hiding this comment.
This is definitely necessary. Thanks for catching it!
I'll also just merge it because it's a simple enough PR that I know you're not adding to it right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.