fix: generate array view#3115
Merged
jpivarski merged 15 commits intoMay 21, 2024
Merged
Conversation
ianna
commented
May 14, 2024
ianna
left a comment
ianna
left a comment
Member
Author
There was a problem hiding this comment.
@jpivarski - I think, this is fixes the issue. However, now I'm thinking what if the numba_type of the array does not match the numba type of the kernel?
jpivarski
approved these changes
May 14, 2024
jpivarski
left a comment
jpivarski
left a comment
Member
There was a problem hiding this comment.
Looks good to me! You can merge when ready.
ianna
commented
May 15, 2024
ianna
left a comment
ianna
left a comment
Member
Author
There was a problem hiding this comment.
@jpivarski - it's strange that the CPU tests on Mac are segfaulting. I'll check it locally.
Member
Author
|
@jpivarski - all the tests pass. Shall I merge it? Thanks. |
Member
|
Yes! In fact, I can do it, since you've just signed-off on it. |
jpivarski
deleted the
ianna/3105-typing-akarray-for-numbacudajit-signature
branch
May 21, 2024 04:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3105