feat: 3154 from_parquet should be able to read partial columns#3156
Merged
tcawlfield merged 5 commits intoJun 24, 2024
Merged
Conversation
This had been bugging me, and with a better understanding now I can improve the unit tests. Mostly for future readability and correctness.
jpivarski
approved these changes
Jun 18, 2024
jpivarski
left a comment
jpivarski
left a comment
Member
There was a problem hiding this comment.
This looks like a good test of partial read-back. This is going through the new metadata, right?
tcawlfield
deleted the
3154-akfrom_parquet-should-be-able-to-read-partial-columns
branch
June 24, 2024 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix a missing feature (or fix a bug, depending on your POV) from 2772.
Also taking the opportunity to clean up test_2772 a tiny little bit. This completes a misunderstanding of mine from issue 3131 (which can be closed or rejected).