Skip to content

fix: requesting layout.form should not touch shape#3189

Merged
jpivarski merged 2 commits into
mainfrom
pivarski/requesting_form_should_not_touch_shape
Jul 31, 2024
Merged

fix: requesting layout.form should not touch shape#3189
jpivarski merged 2 commits into
mainfrom
pivarski/requesting_form_should_not_touch_shape

Conversation

@jpivarski

Copy link
Copy Markdown
Member

@martindurant

Copy link
Copy Markdown
Contributor

Is awkward main still compatible with the last awkward-cpp, so that I can install this simply without recompiling?

@martindurant

Copy link
Copy Markdown
Contributor

I was also going to comment "wow, so many lines", but I see it's all tests for the different classes.

@jpivarski

Copy link
Copy Markdown
Member Author

Is awkward main still compatible with the last awkward-cpp, so that I can install this simply without recompiling?

I think so. I'm testing against main here: https://github.com/scikit-hep/awkward/actions/runs/10163112284

And testing against pivarski/requesting_form_should_not_touch_shape here: https://github.com/scikit-hep/awkward/actions/runs/10163115961

Oh, apparently not. Let me see if I can get a new awkward-cpp into PyPI today.

@jpivarski

Copy link
Copy Markdown
Member Author

A new version of awkward-cpp is available. You can just pip-install it.

@martindurant

Copy link
Copy Markdown
Contributor

This seems to work as intended.
I still don't know how to solve the concat case, though - we can talk about that separately.

@agoose77

Copy link
Copy Markdown
Collaborator

I like this! It makes sense that we don't need any shape-content information to know that the inner_shape is () -- the dimension is a form-level thing.

@jpivarski
jpivarski enabled auto-merge (squash) July 31, 2024 16:25
@jpivarski
jpivarski merged commit 39541db into main Jul 31, 2024
@jpivarski
jpivarski deleted the pivarski/requesting_form_should_not_touch_shape branch July 31, 2024 16:39
pfackeldey pushed a commit to pfackeldey/awkward that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants