Skip to content

feat: to/from PyTorch Tensor#3259

Merged
maxymnaumchyk merged 6 commits into
scikit-hep:mainfrom
maxymnaumchyk:maxymnaumchyk/add-to-from-pytorch-functions
Oct 3, 2024
Merged

feat: to/from PyTorch Tensor#3259
maxymnaumchyk merged 6 commits into
scikit-hep:mainfrom
maxymnaumchyk:maxymnaumchyk/add-to-from-pytorch-functions

Conversation

@maxymnaumchyk

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Sep 27, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 33.96226% with 35 lines in your changes missing coverage. Please review.

Project coverage is 81.94%. Comparing base (b749e49) to head (199468d).
Report is 167 commits behind head on main.

Files with missing lines Patch % Lines
src/awkward/operations/ak_to_torch.py 33.33% 18 Missing ⚠️
src/awkward/operations/ak_from_torch.py 29.16% 17 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/operations/__init__.py 100.00% <100.00%> (ø)
src/awkward/operations/ak_from_torch.py 29.16% <29.16%> (ø)
src/awkward/operations/ak_to_torch.py 33.33% <33.33%> (ø)

... and 105 files with indirect coverage changes

@maxymnaumchyk
maxymnaumchyk marked this pull request as ready for review September 27, 2024 12:32

@jpivarski jpivarski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have a few suggestions.

Comment thread src/awkward/operations/ak_from_torch.py Outdated
Comment thread src/awkward/operations/ak_to_torch.py Outdated
Comment thread src/awkward/operations/ak_to_torch.py Outdated
Comment thread src/awkward/operations/ak_to_torch.py Outdated
Comment thread src/awkward/operations/ak_to_torch.py Outdated
Comment thread src/awkward/operations/ak_to_torch.py
Comment thread src/awkward/operations/ak_to_torch.py Outdated

@ianna ianna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants