feat: updated LayoutBuilder.h (added functors) for C++11 compatibility#3281
Merged
Conversation
…s is not the final version and may contain errors
ianna
marked this pull request as ready for review
November 7, 2024 15:26
ianna
reviewed
Nov 7, 2024
ianna
left a comment
ianna
left a comment
Member
There was a problem hiding this comment.
@jpivarski - all the tests pass. @HavryliukAY - please, check if it works for you. Thanks!
Member
Author
|
I tried to contact @HavryliukAY on Mattermost, but I think he's offline. If this PR is not sufficient, we can do another one later to fix any remaining issues. I'll merge it now. |
Member
Author
|
@all-contributors please add @HavryliukAY for code (I forgot to add you to the contributors because GitHub shows this as my PR. But you did the work!) |
Contributor
|
I've put up a pull request to add @HavryliukAY! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@HavryliukAY, since you said,
I'm going to put it in draft mode. When you're ready for a review, click both "Ready for Review" (below tests) and assign me as a reviewer (top-right).