Skip to content

fix: incorrect passing of Index inside nplike function in to_IndexedOptionArray64#3727

Merged
pfackeldey merged 6 commits into
scikit-hep:mainfrom
ikrommyd:ikrommyd/fix-to_IndexedOptionArray64
Dec 10, 2025
Merged

fix: incorrect passing of Index inside nplike function in to_IndexedOptionArray64#3727
pfackeldey merged 6 commits into
scikit-hep:mainfrom
ikrommyd:ikrommyd/fix-to_IndexedOptionArray64

Conversation

@ikrommyd

@ikrommyd ikrommyd commented Nov 13, 2025

Copy link
Copy Markdown
Member

Fixes #3726

The index's data should be passed into the nplike function. Not the index itself. It's just a typo.

@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.72%. Comparing base (b749e49) to head (2ff2ff3).
⚠️ Report is 484 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/contents/indexedoptionarray.py 89.57% <ø> (+1.36%) ⬆️

... and 199 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3727

@ianna ianna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - thanks for jumping in. Let’s discuss this at the next meeting. Thanks

Comment thread src/awkward/contents/indexedoptionarray.py Outdated
ikrommyd and others added 3 commits December 9, 2025 08:55
Co-authored-by: Peter Fackeldey <fackeldey.peter@gmail.com>
@ikrommyd
ikrommyd force-pushed the ikrommyd/fix-to_IndexedOptionArray64 branch from 73e54c8 to d6efbb8 Compare December 9, 2025 14:57
@ikrommyd
ikrommyd requested a review from pfackeldey December 9, 2025 14:58

@pfackeldey pfackeldey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pfackeldey
pfackeldey merged commit 8872e1f into scikit-hep:main Dec 10, 2025
42 checks passed
@ikrommyd
ikrommyd deleted the ikrommyd/fix-to_IndexedOptionArray64 branch December 10, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IndexedOptionArray.to_IndexedOptionArray64 fails when index dtype is int32

3 participants