Skip to content

fix: make named axis thread-safe and start testing using multiple threads in CI#3805

Merged
ikrommyd merged 9 commits into
scikit-hep:mainfrom
ikrommyd:thread-safety-tests
Jan 24, 2026
Merged

fix: make named axis thread-safe and start testing using multiple threads in CI#3805
ikrommyd merged 9 commits into
scikit-hep:mainfrom
ikrommyd:thread-safety-tests

Conversation

@ikrommyd

Copy link
Copy Markdown
Member

Fixes #3802
Closes #3803

@codecov

codecov Bot commented Jan 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.61%. Comparing base (7661d5a) to head (49ee9a6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/_namedaxis.py 91.28% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3805

Comment thread .github/workflows/test.yml
Comment thread requirements-test-nogil.txt
Comment thread tests/test_2433_copy_behaviors.py
Comment thread tests/test_2596_named_axis.py
Comment thread .github/workflows/test.yml
Comment thread .github/workflows/test.yml
Comment thread src/awkward/_namedaxis.py

@pfackeldey pfackeldey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me know! I'm approving the python side here that makes things thread-safe. @ariostas could you review/approve the CI part of this PR?

@ariostas ariostas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI side looks good to me! It does make sense to separate "nogil" and "basic". We should have done that before. And yeah, we should have been testing 3.14t on macOS.

@ikrommyd

Copy link
Copy Markdown
Member Author

@henryiii said on slack this is good. Can we merge it?

@ianna

ianna commented Jan 24, 2026

Copy link
Copy Markdown
Member

@henryiii said on slack this is good. Can we merge it?

Sure, go ahead 🙌

@ikrommyd
ikrommyd merged commit 2e25dd1 into scikit-hep:main Jan 24, 2026
40 checks passed
@ikrommyd
ikrommyd deleted the thread-safety-tests branch January 24, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start testing Awkward Array with parallel threads in CI Named axis is not thread-safe

4 participants