feat: pass 'offsets' to reducer kernels (precursor to parent removal)#3883
Merged
ianna merged 24 commits intoFeb 20, 2026
Merged
Conversation
… and cuda kernels)
…_argmin_complex and awkward_reduce_argmin kernels
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3883 |
…sum_complex, awkward_reduce_sum_int32_bool_64, awkward_reduce_sum_int64_bool_64. (both CPU and cuda kernels)
…e_argmax kernels. (both CPU and cuda kernels)
…prod_bool, awkward_reduce_prod_complex. (both CPU and cuda kernels)
…mplex and awkward_reduce_argmax, awkward_reduce_prod, awkward_reduce_prod_bool, awkward_reduce_prod_complex.
…ernels. (both CPU and cuda kernels)
… awkward_reduce_sum_bool kernels. (both CPU and cuda kernels)
… awkward_reduce_max, awkward_reduce_max_complex, awkward_reduce_min, awkward_reduce_min_complex
…_prod_bool_complex kernels. (both CPU and cuda kernels)
…wkward_reduce_prod_bool_complex kernels.
…ents were not sorted)
maxymnaumchyk
marked this pull request as ready for review
February 19, 2026 15:25
ianna
approved these changes
Feb 20, 2026
ianna
left a comment
ianna
left a comment
Member
There was a problem hiding this comment.
@maxymnaumchyk - great! All the kernels now take offsets consistently. We’ll define and start using them in the next PR. Thanks!
ianna
enabled auto-merge (squash)
February 20, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step of introducing
offsetsfor kernels. First step: #3865Offsets are now being passed to these reducer kernels:
Except for:
Disclaimer: I used the help of Claude for generating tests at
kernel-test-data.json. I went through them and found some mistakes but I might've missed something.