test: add property-based tests for ak.array_equal#3891
Conversation
…symmetry) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3891 |
|
This will need to wait for the fixes that I’m doing. |
|
@TaiSakuma the error in CI here seems to be the one I mentioned in #3909 (comment). Could you take a look? It looks like it's raised inside hypothesis. |
|
@ikrommyd The from hypothesis import Phase
@settings(max_examples=200, phases=(Phase.generate,))Hypothesis failed to find the simplest sample causing the error likely because the data structure is too complex. |
|
I got this very quickly #3921. We'll see if any other issues arise here after that. |
|
CI is passing now after my fix. |
|
I started seeing the same error in my PR too. I will ask Ashwin. |
|
I also see that building an environment is failing at |
|
Okay yeah. I was just letting you know. They are not required to merge things so as long as a PR does not touch GPU stuff, we are fine. |
|
@TaiSakuma is this good to go from your side? |
|
@ikrommyd Yes. It is great that these tests pass now. |
|
From what it seems, there is a version incompatibility. So, if we pin |
From CUDA installation instructions: https://docs.nvidia.com/cuda/cuda-installation-guide-linux/ The following metapackages will install the latest version of the named component on Linux for the indicated CUDA version. “cu12” should be read as “cuda12”. These metapackages install the following packages: |
|
We can merge this one anyways though since GPU tests are not required and the tests added here have nothing to do with GPUs. |
ianna
left a comment
There was a problem hiding this comment.
@TaiSakuma - thanks, this is great! I don’t think we need to wait for GPU runners to be fixed before we merge this one. Thanks
Sure, go ahead👍 |
Following #3887, this PR adds another property-based test.
ak.array_equal().ak.to_buffers()andak.from_buffers(), added in test: introduce property-based testing with to_buffers/from_buffers roundtrip #3887