Skip to content

chore: Increase coverage target from 20% to 98%#3897

Merged
ianna merged 3 commits into
mainfrom
ianna/increase_coverage_target
Feb 27, 2026
Merged

chore: Increase coverage target from 20% to 98%#3897
ianna merged 3 commits into
mainfrom
ianna/increase_coverage_target

Conversation

@ianna

@ianna ianna commented Feb 26, 2026

Copy link
Copy Markdown
Member

as discussed at the meeting

@ianna
ianna requested a review from ikrommyd February 26, 2026 20:27
@github-actions

Copy link
Copy Markdown

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3897

Comment thread codecov.yml Outdated
@ianna
ianna requested a review from ariostas February 26, 2026 21:08
Comment thread codecov.yml
Comment thread codecov.yml
@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.65%. Comparing base (7911123) to head (1b44731).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ianna ianna left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas and @ikrommyd - I think I'm happy with the final configuration. Ignoring a few paths which cannot be checked (no GPU, nor ROOT) will significantly increase our current coverage. I'd like to see how close we are to 💯

@ariostas ariostas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. We'll see how painful it ends up being trying to hit the 98% mark. It it's only hard sometimes we can just ignore the failure in those cases, but if it regularly happens that the tests needed are too convoluted we can just decrease it a bit.

@ianna
ianna merged commit a6c3b25 into main Feb 27, 2026
41 checks passed
@ianna
ianna deleted the ianna/increase_coverage_target branch February 27, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants