You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
@ikrommyd - great, thanks. Would it make sense to expand the tests to include axis parameter, deeply nested structures, record arrays, negative tests (e.g. with an invalid axis or bad nested structure), also type/shape checks?
Yeah I can add a little bit more testing although it would be over-testing mostly cause the only thing we want to test really is that generator expressions just behave the same as other iterables like lists or tuples (assuming axes and nestedness is tested in other tests).
Yeah I can add a little bit more testing although it would be over-testing mostly cause the only thing we want to test really is that generator expressions just behave the same as other iterables like lists or tuples (assuming axes and nestedness is tested in other tests).
I don't know if these are tested for generators... you might be right
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.28%. Comparing base (7499387) to head (30199d8). ⚠️ Report is 3 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3937