Skip to content

Use appropriate storage location + migrate events #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Aug 1, 2025

  • Use applicationSupportDirectory for storage instead of documents/cache.
  • Migrate any existing event batches.
  • Added test to verify migration.

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.91%. Comparing base (96380e2) to head (3701acc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Segment/Utilities/Utils.swift 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   70.80%   70.91%   +0.11%     
==========================================
  Files          49       49              
  Lines        4894     4920      +26     
==========================================
+ Hits         3465     3489      +24     
- Misses       1429     1431       +2     
Files with missing lines Coverage Δ
Sources/Segment/State.swift 97.35% <ø> (-0.02%) ⬇️
Sources/Segment/Utilities/Utils.swift 67.56% <96.77%> (+16.50%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsneed bsneed merged commit a4c12ae into main Aug 1, 2025
24 of 27 checks passed
@bsneed bsneed deleted the bsneed/storage_location branch August 1, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants