Add TxHash to Message #1073
Open
Add TxHash to Message #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstout
force-pushed
the
expose_msg_tx_hash
branch
from
cd5d7fc to
67eda25
Compare
TxHash was recently added to the Sequence type in contract_reader. In this commit we bump the version of chainlink-common to access this new field and use it to populate the TxHash field of Message. The forthcoming CCTPv2 attestation logic needs TxHash to fetch attestations for a Message's USDC transfers.
rstout
force-pushed
the
expose_msg_tx_hash
branch
from
67eda25 to
d425345
Compare
rstout
requested review from
winder,
asoliman92,
matYang,
makramkd,
AmrMohamedRezk,
0xAustinWang and
b-gopalswami
| @@ -172,6 +174,7 @@ func (l *DefaultAccessor) MsgsBetweenSeqNums( | |||
| } | |||
|
|
|||
| msg.Message.Header.OnRamp = onRampAddress | |||
| msg.Message.Header.TxHash = "0x" + hex.EncodeToString(item.TxHash) | |||
There was a problem hiding this comment.
I suppose this pattern is already implemented as Bytes.String() function. It might be worth replacing it with NewBytesFromString(item.TxHash).String() or something similar
There was a problem hiding this comment.
Can we have a tiny unit test to cover that change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TxHash was recently added to the Sequence type in contract_reader. In this commit we bump the version of chainlink-common to access this new field and use it to populate the TxHash field of Message. The forthcoming CCTPv2 attestation logic needs TxHash to fetch attestations for a Message's USDC transfers.