Skip to content

Commit 848274f

Browse files
committed
Squashed commit of the following:
commit 17dfe8e Author: thinkyhead <[email protected]> Date: Wed Apr 3 00:20:46 2024 +0000 [cron] Bump distribution date (2024-04-03) commit 7b6b6e1 Author: Scott Lahteine <[email protected]> Date: Mon Apr 1 21:44:18 2024 -0500 🩹 Revert motion change commit 60f2837 Author: Sophist <[email protected]> Date: Tue Apr 2 03:30:04 2024 +0100 🔧 Minor INPUT_SHAPING config fixes (MarlinFirmware#26882) Co-authored-by: Scott Lahteine <[email protected]> commit ef5fb39 Author: thinkyhead <[email protected]> Date: Tue Apr 2 00:20:47 2024 +0000 [cron] Bump distribution date (2024-04-02) commit 87e94f4 Author: Andrew <[email protected]> Date: Mon Apr 1 16:05:11 2024 -0400 🚸 Update ProUI Plot graph - part 2 (MarlinFirmware#26563) Co-authored-by: Scott Lahteine <[email protected]> commit 017a903 Author: thinkyhead <[email protected]> Date: Mon Apr 1 00:23:48 2024 +0000 [cron] Bump distribution date (2024-04-01) commit 466282f Author: Scott Lahteine <[email protected]> Date: Sun Mar 31 18:20:37 2024 -0500 🩹 Misc. changes from ProUI / ExtUI updates (MarlinFirmware#26928) commit 1759429 Author: thinkyhead <[email protected]> Date: Thu Mar 28 00:20:53 2024 +0000 [cron] Bump distribution date (2024-03-28) commit 0b9f487 Author: Jordan Stocker <[email protected]> Date: Thu Mar 28 06:14:03 2024 +1030 🔨 Fix binary upload firmware path (MarlinFirmware#26909) commit d3e1a92 Author: Chris <[email protected]> Date: Wed Mar 27 20:39:54 2024 +0100 🔨 Fix HC32 preflight (MarlinFirmware#26912) commit cd357b0 Author: Holger Mößinger <[email protected]> Date: Wed Mar 27 20:38:08 2024 +0100 🔧🚸 Tweaks for (MiniRambo) CNC (MarlinFirmware#26892) Co-authored-by: Scott Lahteine <[email protected]> commit d0d229e Author: thinkyhead <[email protected]> Date: Mon Mar 25 00:21:58 2024 +0000 [cron] Bump distribution date (2024-03-25) commit eb897e6 Author: Ikko Eltociear Ashimine <[email protected]> Date: Mon Mar 25 03:49:25 2024 +0900 📝 Fix Cutter.md typo (MarlinFirmware#26901) commit 825ebfd Author: thinkyhead <[email protected]> Date: Sun Mar 24 00:23:21 2024 +0000 [cron] Bump distribution date (2024-03-24) commit 3ee3964 Author: John Robertson <[email protected]> Date: Sat Mar 23 00:57:23 2024 +0000 🐛 Fix ESP32 laser M4 exception (MarlinFirmware#26884) commit aecfb25 Author: Sophist <[email protected]> Date: Sat Mar 23 00:27:13 2024 +0000 🚸 Hide auto-run as needed (MarlinFirmware#26853) commit 896a6a9 Author: thinkyhead <[email protected]> Date: Sat Mar 23 00:20:15 2024 +0000 [cron] Bump distribution date (2024-03-23) commit 075f96d Author: Holger Mößinger <[email protected]> Date: Fri Mar 22 22:36:42 2024 +0100 ✏️ Fix stepper MS pin typos (MarlinFirmware#26891) commit 0589655 Author: thinkyhead <[email protected]> Date: Mon Mar 18 00:21:39 2024 +0000 [cron] Bump distribution date (2024-03-18) commit ea6a891 Author: Manuel McLure <[email protected]> Date: Sun Mar 17 12:23:12 2024 -0700 ✨ MAX7219_REINIT_ON_POWERUP (MarlinFirmware#26163)
1 parent 217a15d commit 848274f

File tree

175 files changed

+2276
-1124
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

175 files changed

+2276
-1124
lines changed

Marlin/Configuration.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2638,9 +2638,9 @@
26382638
#define DISPLAY_CHARSET_HD44780 WESTERN
26392639

26402640
/**
2641-
* Info Screen Style (0:Classic, 1:Průša)
2641+
* Info Screen Style (0:Classic, 1:Průša, 2:CNC)
26422642
*
2643-
* :[0:'Classic', 1:'Průša']
2643+
* :[0:'Classic', 1:'Průša', 2:'CNC']
26442644
*/
26452645
#define LCD_INFO_SCREEN_STYLE 0
26462646

Marlin/Configuration_adv.h

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,14 +1203,14 @@
12031203
//#define INPUT_SHAPING_Y
12041204
#if ANY(INPUT_SHAPING_X, INPUT_SHAPING_Y)
12051205
#if ENABLED(INPUT_SHAPING_X)
1206-
#define SHAPING_FREQ_X 40 // (Hz) The default dominant resonant frequency on the X axis.
1207-
#define SHAPING_ZETA_X 0.15f // Damping ratio of the X axis (range: 0.0 = no damping to 1.0 = critical damping).
1206+
#define SHAPING_FREQ_X 40.0 // (Hz) The default dominant resonant frequency on the X axis.
1207+
#define SHAPING_ZETA_X 0.15 // Damping ratio of the X axis (range: 0.0 = no damping to 1.0 = critical damping).
12081208
#endif
12091209
#if ENABLED(INPUT_SHAPING_Y)
1210-
#define SHAPING_FREQ_Y 40 // (Hz) The default dominant resonant frequency on the Y axis.
1211-
#define SHAPING_ZETA_Y 0.15f // Damping ratio of the Y axis (range: 0.0 = no damping to 1.0 = critical damping).
1210+
#define SHAPING_FREQ_Y 40.0 // (Hz) The default dominant resonant frequency on the Y axis.
1211+
#define SHAPING_ZETA_Y 0.15 // Damping ratio of the Y axis (range: 0.0 = no damping to 1.0 = critical damping).
12121212
#endif
1213-
//#define SHAPING_MIN_FREQ 20 // By default the minimum of the shaping frequencies. Override to affect SRAM usage.
1213+
//#define SHAPING_MIN_FREQ 20.0 // (Hz) By default the minimum of the shaping frequencies. Override to affect SRAM usage.
12141214
//#define SHAPING_MAX_STEPRATE 10000 // By default the maximum total step rate of the shaped axes. Override to affect SRAM usage.
12151215
//#define SHAPING_MENU // Add a menu to the LCD to set shaping parameters.
12161216
#endif
@@ -3560,7 +3560,7 @@
35603560
* Add the M3, M4, and M5 commands to turn the spindle/laser on and off, and
35613561
* to set spindle speed, spindle direction, and laser power.
35623562
*
3563-
* SuperPid is a router/spindle speed controller used in the CNC milling community.
3563+
* SuperPID is a router/spindle speed controller used in the CNC milling community.
35643564
* Marlin can be used to turn the spindle on and off. It can also be used to set
35653565
* the spindle speed from 5,000 to 30,000 RPM.
35663566
*
@@ -4314,6 +4314,7 @@
43144314
// See class CodeProfiler.
43154315
//#define MAX7219_DEBUG_MULTISTEPPING 6 // Show multi-stepping 1 to 128 on this LED matrix row.
43164316
//#define MAX7219_DEBUG_SLOWDOWN 6 // Count (mod 16) how many times SLOWDOWN has reduced print speed.
4317+
//#define MAX7219_REINIT_ON_POWERUP // Re-initialize MAX7129 when power supply turns on
43174318
#endif
43184319

43194320
/**

Marlin/Version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
* here we define this default string as the date where the latest release
4242
* version was tagged.
4343
*/
44-
//#define STRING_DISTRIBUTION_DATE "2024-03-17"
44+
//#define STRING_DISTRIBUTION_DATE "2024-04-03"
4545

4646
/**
4747
* Defines a generic printer name to be output to the LCD after booting Marlin.

Marlin/src/MarlinCore.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@
7777
#include "lcd/e3v2/common/encoder.h"
7878
#if ENABLED(DWIN_CREALITY_LCD)
7979
#include "lcd/e3v2/creality/dwin.h"
80-
#elif ENABLED(DWIN_LCD_PROUI)
81-
#include "lcd/e3v2/proui/dwin.h"
8280
#elif ENABLED(DWIN_CREALITY_LCD_JYERSUI)
8381
#include "lcd/e3v2/jyersui/dwin.h"
8482
#endif
@@ -1594,11 +1592,11 @@ void setup() {
15941592
SERIAL_ECHO_TERNARY(err, "BL24CXX Check ", "failed", "succeeded", "!\n");
15951593
#endif
15961594

1597-
#if HAS_DWIN_E3V2_BASIC
1595+
#if ENABLED(DWIN_CREALITY_LCD)
15981596
SETUP_RUN(dwinInitScreen());
15991597
#endif
16001598

1601-
#if HAS_SERVICE_INTERVALS && !HAS_DWIN_E3V2_BASIC
1599+
#if HAS_SERVICE_INTERVALS && DISABLED(DWIN_CREALITY_LCD)
16021600
SETUP_RUN(ui.reset_status(true)); // Show service messages or keep current status
16031601
#endif
16041602

Marlin/src/feature/bedlevel/ubl/ubl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class unified_bed_leveling {
9595
static void report_current_mesh();
9696
static void report_state();
9797
static void save_ubl_active_state_and_disable();
98-
static void restore_ubl_active_state_and_leave();
98+
static void restore_ubl_active_state(const bool is_done=true);
9999
static void display_map(const uint8_t) __O0;
100100
static mesh_index_pair find_closest_mesh_point_of_type(const MeshPointType, const xy_pos_t&, const bool=false, MeshFlags *done_flags=nullptr) __O0;
101101
static mesh_index_pair find_furthest_invalid_mesh_point() __O0;

Marlin/src/feature/bedlevel/ubl/ubl_G29.cpp

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ void unified_bed_leveling::G29() {
309309
#if ALL(DWIN_LCD_PROUI, ZHOME_BEFORE_LEVELING)
310310
save_ubl_active_state_and_disable();
311311
gcode.process_subcommands_now(F("G28Z"));
312-
restore_ubl_active_state_and_leave();
312+
restore_ubl_active_state(false); // ...without telling ExtUI "done"
313313
#else
314314
// Send 'N' to force homing before G29 (internal only)
315315
if (axes_should_home() || parser.seen_test('N')) gcode.home_all_axes();
@@ -425,7 +425,7 @@ void unified_bed_leveling::G29() {
425425
if (parser.seen_test('J')) {
426426
save_ubl_active_state_and_disable();
427427
tilt_mesh_based_on_probed_grid(param.J_grid_size == 0); // Zero size does 3-Point
428-
restore_ubl_active_state_and_leave();
428+
restore_ubl_active_state();
429429
#if ENABLED(UBL_G29_J_RECENTER)
430430
do_blocking_move_to_xy(0.5f * ((MESH_MIN_X) + (MESH_MAX_X)), 0.5f * ((MESH_MIN_Y) + (MESH_MAX_Y)));
431431
#endif
@@ -754,7 +754,6 @@ void unified_bed_leveling::shift_mesh_height() {
754754

755755
TERN_(HAS_MARLINUI_MENU, ui.capture());
756756
TERN_(EXTENSIBLE_UI, ExtUI::onLevelingStart());
757-
TERN_(DWIN_LCD_PROUI, dwinLevelingStart());
758757

759758
save_ubl_active_state_and_disable(); // No bed level correction so only raw data is obtained
760759
grid_count_t count = GRID_MAX_POINTS;
@@ -768,7 +767,6 @@ void unified_bed_leveling::shift_mesh_height() {
768767
SERIAL_ECHOLNPGM("Probing mesh point ", point_num, "/", GRID_MAX_POINTS, ".");
769768
TERN_(HAS_STATUS_MESSAGE, ui.status_printf(0, F(S_FMT " %i/%i"), GET_TEXT(MSG_PROBING_POINT), point_num, int(GRID_MAX_POINTS)));
770769
TERN_(HAS_BACKLIGHT_TIMEOUT, ui.refresh_backlight_timeout());
771-
TERN_(DWIN_LCD_PROUI, dwinRedrawScreen());
772770

773771
#if HAS_MARLINUI_MENU
774772
if (ui.button_pressed()) {
@@ -778,8 +776,7 @@ void unified_bed_leveling::shift_mesh_height() {
778776
ui.quick_feedback();
779777
ui.release();
780778
probe.stow(); // Release UI before stow to allow for PAUSE_BEFORE_DEPLOY_STOW
781-
TERN_(EXTENSIBLE_UI, ExtUI::onLevelingDone());
782-
return restore_ubl_active_state_and_leave();
779+
return restore_ubl_active_state();
783780
}
784781
#endif
785782

@@ -815,15 +812,12 @@ void unified_bed_leveling::shift_mesh_height() {
815812

816813
probe.move_z_after_probing();
817814

818-
restore_ubl_active_state_and_leave();
819-
820815
do_blocking_move_to_xy(
821816
constrain(nearby.x - probe.offset_xy.x, MESH_MIN_X, MESH_MAX_X),
822817
constrain(nearby.y - probe.offset_xy.y, MESH_MIN_Y, MESH_MAX_Y)
823818
);
824819

825-
TERN_(EXTENSIBLE_UI, ExtUI::onLevelingDone());
826-
TERN_(DWIN_LCD_PROUI, dwinLevelingDone());
820+
restore_ubl_active_state();
827821
}
828822

829823
#endif // HAS_BED_PROBE
@@ -932,7 +926,7 @@ void set_message_with_feedback(FSTR_P const fstr) {
932926
if (param.V_verbosity > 1)
933927
SERIAL_ECHOLNPGM("Business Card is ", p_float_t(thickness, 4), "mm thick.");
934928

935-
restore_ubl_active_state_and_leave();
929+
restore_ubl_active_state();
936930

937931
return thickness;
938932
}
@@ -987,7 +981,7 @@ void set_message_with_feedback(FSTR_P const fstr) {
987981
if (_click_and_hold([]{
988982
SERIAL_ECHOLNPGM("\nMesh only partially populated.");
989983
do_z_clearance(Z_CLEARANCE_DEPLOY_PROBE);
990-
})) return restore_ubl_active_state_and_leave();
984+
})) return restore_ubl_active_state();
991985

992986
// Store the Z position minus the shim height
993987
z_values[lpos.x][lpos.y] = current_position.z - thick;
@@ -1002,10 +996,8 @@ void set_message_with_feedback(FSTR_P const fstr) {
1002996

1003997
if (do_ubl_mesh_map) display_map(param.T_map_type); // show user where we're probing
1004998

1005-
restore_ubl_active_state_and_leave();
999+
restore_ubl_active_state();
10061000
do_blocking_move_to_xy_z(pos, Z_CLEARANCE_DEPLOY_PROBE);
1007-
1008-
TERN_(EXTENSIBLE_UI, ExtUI::onLevelingDone());
10091001
}
10101002

10111003
/**
@@ -1111,7 +1103,7 @@ void set_message_with_feedback(FSTR_P const fstr) {
11111103
} while (lpos.x >= 0 && --param.R_repetition > 0);
11121104

11131105
if (do_ubl_mesh_map) display_map(param.T_map_type);
1114-
restore_ubl_active_state_and_leave();
1106+
restore_ubl_active_state();
11151107

11161108
do_blocking_move_to_xy_z(pos, Z_TWEEN_SAFE_CLEARANCE);
11171109

@@ -1263,17 +1255,20 @@ void unified_bed_leveling::save_ubl_active_state_and_disable() {
12631255
set_bed_leveling_enabled(false);
12641256
}
12651257

1266-
void unified_bed_leveling::restore_ubl_active_state_and_leave() {
1258+
void unified_bed_leveling::restore_ubl_active_state(const bool is_done/*=true*/) {
12671259
TERN_(HAS_MARLINUI_MENU, ui.release());
12681260
#if ENABLED(UBL_DEVEL_DEBUGGING)
12691261
if (--ubl_state_recursion_chk) {
1270-
SERIAL_ECHOLNPGM("restore_ubl_active_state_and_leave() called too many times.");
1262+
SERIAL_ECHOLNPGM("restore_ubl_active_state() called too many times.");
12711263
set_message_with_feedback(GET_TEXT_F(MSG_UBL_RESTORE_ERROR));
12721264
return;
12731265
}
12741266
#endif
12751267
set_bed_leveling_enabled(ubl_state_at_invocation);
1276-
TERN_(EXTENSIBLE_UI, ExtUI::onLevelingDone());
1268+
1269+
if (is_done) {
1270+
TERN_(EXTENSIBLE_UI, ExtUI::onLevelingDone());
1271+
}
12771272
}
12781273

12791274
mesh_index_pair unified_bed_leveling::find_furthest_invalid_mesh_point() {

Marlin/src/feature/host_actions.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,13 @@ void HostUI::action(FSTR_P const fstr, const bool eol) {
186186
switch (response) {
187187

188188
case 0: // "Purge More" button
189-
#if ALL(M600_PURGE_MORE_RESUMABLE, ADVANCED_PAUSE_FEATURE)
189+
#if ENABLED(M600_PURGE_MORE_RESUMABLE)
190190
pause_menu_response = PAUSE_RESPONSE_EXTRUDE_MORE; // Simulate menu selection (menu exits, doesn't extrude more)
191191
#endif
192192
break;
193193

194194
case 1: // "Continue" / "Disable Runout" button
195-
#if ALL(M600_PURGE_MORE_RESUMABLE, ADVANCED_PAUSE_FEATURE)
195+
#if ENABLED(M600_PURGE_MORE_RESUMABLE)
196196
pause_menu_response = PAUSE_RESPONSE_RESUME_PRINT; // Simulate menu selection
197197
#endif
198198
#if HAS_FILAMENT_SENSOR

Marlin/src/feature/leds/printer_event_leds.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class PrinterEventLEDs {
5656

5757
#if HAS_TEMP_HOTEND || HAS_HEATED_BED || HAS_HEATED_CHAMBER
5858
static void onHeatingDone() { leds.set_white(); }
59-
static void onPidTuningDone(LEDColor c) { leds.set_color(c); }
59+
static void onPIDTuningDone(LEDColor c) { leds.set_color(c); }
6060
#endif
6161

6262
#if HAS_MEDIA

Marlin/src/feature/max7219.cpp

Lines changed: 43 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,26 @@
7272
uint16_t CodeProfiler::call_count = 0;
7373
#endif
7474

75+
#if defined(MAX7219_DEBUG_PLANNER_HEAD) && defined(MAX7219_DEBUG_PLANNER_TAIL) && MAX7219_DEBUG_PLANNER_HEAD == MAX7219_DEBUG_PLANNER_TAIL
76+
static int16_t last_head_cnt = 0xF, last_tail_cnt = 0xF;
77+
#else
78+
#ifdef MAX7219_DEBUG_PLANNER_HEAD
79+
static int16_t last_head_cnt = 0x1;
80+
#endif
81+
#ifdef MAX7219_DEBUG_PLANNER_TAIL
82+
static int16_t last_tail_cnt = 0x1;
83+
#endif
84+
#endif
85+
#ifdef MAX7219_DEBUG_PLANNER_QUEUE
86+
static int16_t last_depth = 0;
87+
#endif
88+
#ifdef MAX7219_DEBUG_PROFILE
89+
static uint8_t last_time_fraction = 0;
90+
#endif
91+
#ifdef MAX7219_DEBUG_MULTISTEPPING
92+
static uint8_t last_multistepping = 0;
93+
#endif
94+
7595
Max7219 max7219;
7696

7797
uint8_t Max7219::led_line[MAX7219_LINES]; // = { 0 };
@@ -550,6 +570,29 @@ void Max7219::init() {
550570
#if MAX7219_INIT_TEST
551571
start_test_pattern();
552572
#endif
573+
574+
#ifdef MAX7219_REINIT_ON_POWERUP
575+
#if defined(MAX7219_DEBUG_PLANNER_HEAD) && defined(MAX7219_DEBUG_PLANNER_TAIL) && MAX7219_DEBUG_PLANNER_HEAD == MAX7219_DEBUG_PLANNER_TAIL
576+
last_head_cnt = 0xF;
577+
last_tail_cnt = 0xF;
578+
#else
579+
#ifdef MAX7219_DEBUG_PLANNER_HEAD
580+
last_head_cnt = 0x1;
581+
#endif
582+
#ifdef MAX7219_DEBUG_PLANNER_TAIL
583+
last_tail_cnt = 0x1;
584+
#endif
585+
#endif
586+
#ifdef MAX7219_DEBUG_PLANNER_QUEUE
587+
last_depth = 0;
588+
#endif
589+
#ifdef MAX7219_DEBUG_PROFILE
590+
last_time_fraction = 0;
591+
#endif
592+
#ifdef MAX7219_DEBUG_MULTISTEPPING
593+
last_multistepping = 0;
594+
#endif
595+
#endif
553596
}
554597

555598
/**
@@ -676,8 +719,6 @@ void Max7219::idle_tasks() {
676719

677720
#if defined(MAX7219_DEBUG_PLANNER_HEAD) && defined(MAX7219_DEBUG_PLANNER_TAIL) && MAX7219_DEBUG_PLANNER_HEAD == MAX7219_DEBUG_PLANNER_TAIL
678721

679-
static int16_t last_head_cnt = 0xF, last_tail_cnt = 0xF;
680-
681722
if (last_head_cnt != head || last_tail_cnt != tail) {
682723
range16(MAX7219_DEBUG_PLANNER_HEAD, last_tail_cnt, tail, last_head_cnt, head, &row_change_mask);
683724
last_head_cnt = head;
@@ -687,15 +728,13 @@ void Max7219::idle_tasks() {
687728
#else
688729

689730
#ifdef MAX7219_DEBUG_PLANNER_HEAD
690-
static int16_t last_head_cnt = 0x1;
691731
if (last_head_cnt != head) {
692732
mark16(MAX7219_DEBUG_PLANNER_HEAD, last_head_cnt, head, &row_change_mask);
693733
last_head_cnt = head;
694734
}
695735
#endif
696736

697737
#ifdef MAX7219_DEBUG_PLANNER_TAIL
698-
static int16_t last_tail_cnt = 0x1;
699738
if (last_tail_cnt != tail) {
700739
mark16(MAX7219_DEBUG_PLANNER_TAIL, last_tail_cnt, tail, &row_change_mask);
701740
last_tail_cnt = tail;
@@ -714,7 +753,6 @@ void Max7219::idle_tasks() {
714753
#endif
715754

716755
#ifdef MAX7219_DEBUG_PROFILE
717-
static uint8_t last_time_fraction = 0;
718756
const uint8_t current_time_fraction = (uint16_t(CodeProfiler::get_time_fraction()) * MAX7219_NUMBER_UNITS + 8) / 16;
719757
if (current_time_fraction != last_time_fraction) {
720758
quantity(MAX7219_DEBUG_PROFILE, last_time_fraction, current_time_fraction, &row_change_mask);

Marlin/src/feature/pause.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
/**
2424
* feature/pause.cpp - Pause feature support functions
2525
* This may be combined with related G-codes if features are consolidated.
26+
*
27+
* Note: Calls to ui.pause_show_message are passed to either ExtUI or MarlinUI.
2628
*/
2729

2830
#include "../inc/MarlinConfigPre.h"
@@ -60,8 +62,6 @@
6062

6163
#if ENABLED(EXTENSIBLE_UI)
6264
#include "../lcd/extui/ui_api.h"
63-
#elif ENABLED(DWIN_LCD_PROUI)
64-
#include "../lcd/e3v2/proui/dwin.h"
6565
#endif
6666

6767
#include "../lcd/marlinui.h"
@@ -148,7 +148,7 @@ static bool ensure_safe_temperature(const bool wait=true, const PauseMode mode=P
148148
thermalManager.setTargetHotend(thermalManager.extrude_min_temp, active_extruder);
149149
#endif
150150

151-
ui.pause_show_message(PAUSE_MESSAGE_HEATING, mode); UNUSED(mode);
151+
ui.pause_show_message(PAUSE_MESSAGE_HEATING, mode);
152152

153153
if (wait) return thermalManager.wait_for_hotend(active_extruder);
154154

@@ -288,8 +288,8 @@ bool load_filament(const_float_t slow_load_length/*=0*/, const_float_t fast_load
288288
// Show "Purge More" / "Resume" menu and wait for reply
289289
KEEPALIVE_STATE(PAUSED_FOR_USER);
290290
wait_for_user = false;
291-
#if ANY(HAS_MARLINUI_MENU, DWIN_LCD_PROUI)
292-
ui.pause_show_message(PAUSE_MESSAGE_OPTION); // Also sets PAUSE_RESPONSE_WAIT_FOR
291+
#if ANY(HAS_MARLINUI_MENU, EXTENSIBLE_UI)
292+
ui.pause_show_message(PAUSE_MESSAGE_OPTION); // MarlinUI and MKS UI also set PAUSE_RESPONSE_WAIT_FOR
293293
#else
294294
pause_menu_response = PAUSE_RESPONSE_WAIT_FOR;
295295
#endif

0 commit comments

Comments
 (0)