Athena support #2372
Draft
Athena support #2372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niels-b
force-pushed
the
obsl-593-core-add-athena-support
branch
from
f4624bc to
d5bd638
Compare
|
Niels-b
commented
Aug 14, 2025
| @@ -5,8 +5,19 @@ | |||
|
|
|||
| def convert_datetime_to_str(dt: datetime) -> Optional[str]: | |||
There was a problem hiding this comment.
This function gave issues with other DBs as well.
Changed it so the timezone is now set accordingly (see comments)
| assert str(check_result.data_timestamp) == "2025-01-04 10:00:00+00:00" | ||
| assert str(check_result.data_timestamp) in [ | ||
| "2025-01-04 10:00:00+00:00", | ||
| "2025-01-04 10:00:00", |
There was a problem hiding this comment.
We're not checking for a timestamp here, so if it's not included it's okay. But someone might have a different opinion, so I'm mentioning/highlighting it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.