-
Notifications
You must be signed in to change notification settings - Fork 218
feat: date picker polishing #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: date picker polishing #801
Conversation
…missing import for CodePreview # Conflicts: # apps/app/src/app/pages/(components)/components/(date-picker)/date-picker.page.ts
…n/ui * update styles for multi picker
5d55310
to
29c46dc
Compare
Hey @marcjulian im not sure why we are ignoring the null value in the writeValue method, we should write also null, because the writeValue is also called, when you update a value via formcontrol. What do you think? |
@MerlinMoos do you mean this part? spartan/libs/helm/date-picker/src/lib/hlm-date-picker.ts Lines 136 to 142 in 20c315e
The current type for the date is either
Should we update the date to or should we set the date to public readonly date = model<T | null>(); One more thing, should the |
Hey, I made the changes in my pr for the date range picker, we just should merge your polishing and I resolved the writeValue issue and the Model as a binding, this is rasing to many change events |
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/spartan-ng/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
Primitives
Others
What is the current behavior?
What is the new behavior?
Components
buttonId
input to connect a label to the buttontext-muted-foreground
from the placeholder text, following shadcn/ui stylesDocs
label
to all examples and connect them to the date-picker button<input type="time" />
(datepicker: Extend DatePicker to Support Time-Only Selection in Spartan-NG #707)Does this PR introduce a breaking change?
Changing the multi picker icon to chevron down to have the same styles as the normal date-picker.
Other information