Skip to content

feat: sheet polishing #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: sheet polishing #810

wants to merge 3 commits into from

Conversation

marcjulian
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

Primitives

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • breadcrumb
  • button
  • calendar
  • card
  • carousel
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • form-field
  • hover-card
  • icon
  • input
  • input-otp
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toggle
  • toggle-group
  • tooltip
  • typography

Others

  • trpc
  • nx
  • repo
  • cli

What is the current behavior?

What is the new behavior?

  • add size docs example
  • add close button to preview
  • use linkedSignal for side state
  • add input comments and use readonly for property

Does this PR introduce a breaking change?

  • Yes
  • No

Changed side state to a linkedSignal and changed the name from sideInputState to sideState.

Other information

@marcjulian marcjulian changed the title feat/sheet polishing feat: sheet polishing Aug 7, 2025
ashley-hunter
ashley-hunter approved these changes Aug 8, 2025
View reviewed changes
Copy link
Collaborator

@ashley-hunter ashley-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, changes looks great!

@marcjulian
docs(sheet): add size example and add close button to preview
d19f7e0 
# Conflicts:
#	apps/app/src/app/pages/(components)/components/(sheet)/sheet.generated.ts
#	apps/app/src/app/pages/(components)/components/(sheet)/sheet.page.ts
@marcjulian
feat(sheet): use linkedSignal for side state
2c96742
@marcjulian
feat(sheet): add input comments and use readonly for property
1d92f74
@marcjulian marcjulian force-pushed the feat/sheet-polishing branch from 9f453b4 to 1d92f74 Compare August 13, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashley-hunter ashley-hunter ashley-hunter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcjulian @ashley-hunter