feat: separator polishing #811
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashley-hunter
approved these changes
Aug 8, 2025
marcjulian
force-pushed
the
feat/separator-polishing
branch
from
2a47cab to
39e5f45
Compare
|
@marcjulian this also just needs an update to the snapshot and some conflict resolutions! but loks great! |
…o directive * use brn-separator as host directive for hlm-separator * inline orientation type for api docs
# Conflicts: # apps/app/src/app/pages/(components)/components/(separator)/separator.generated.ts
# Conflicts: # libs/cli/generators.json # libs/cli/src/generators/healthcheck/generator.ts
marcjulian
force-pushed
the
feat/separator-polishing
branch
from
39e5f45 to
ca63826
Compare
|
@goetzrobin conflicts are resolved and updated the snapshot too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/spartan-ng/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
Primitives
Others
What is the current behavior?
What is the new behavior?
Simplify separator by turning
brn-separatorinto a directive and using it as host directive forhlm-separator. Remove duplicateorientationinputs.Added migration and health check for
brn-separatortohlm-separator.Does this PR introduce a breaking change?
Template is different compared to before.
Other information