Skip to content

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Oct 24, 2022

Fixes #7 + #16

This requires proj:epsg in the scope where proj fields are used.

This might be an issue for cases where currently proj:epsg is in Item properties and the individual assets use proj:shape/proj:transform only. I think I've seen that in implementations...

@m-mohr m-mohr requested a review from matthewhanson October 24, 2022 13:01
@m-mohr
Copy link
Contributor Author

m-mohr commented Oct 24, 2022

Dev call: Don't require proj:epsg at all (but say that having EPSG would be great), see #7 for more discussions. Thus, the schema in this PR needs an update.

@m-mohr m-mohr closed this Oct 24, 2022
@m-mohr m-mohr deleted the issue-7 branch October 24, 2022 15:41
@m-mohr m-mohr restored the issue-7 branch October 24, 2022 15:41
@m-mohr m-mohr reopened this Oct 24, 2022
# Conflicts:
#	CHANGELOG.md
#	README.md
@m-mohr m-mohr requested review from hobu, emmanuelmathot and gadomski and removed request for hobu February 6, 2023 11:52
@m-mohr
Copy link
Contributor Author

m-mohr commented Feb 6, 2023

As discussed in a STAC meeting last year, we are removing the proj:epsg requirement. Updated this PR to reflect that, I'd appreciate a new round of reviews.

Copy link
Member

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me.

Co-authored-by: Pete Gadomski <[email protected]>
@m-mohr m-mohr linked an issue Feb 6, 2023 that may be closed by this pull request
@m-mohr m-mohr merged commit 091e98b into main Feb 7, 2023
@m-mohr m-mohr deleted the issue-7 branch February 7, 2023 16:52
jlaura pushed a commit to jlaura/projection that referenced this pull request Apr 3, 2023
* Add more examples, clarify/fix `proj:epsg` requirement stac-extensions#7, align repo with template

* Don't require proj:epsg as discussed in the STAC meeting

* Clarification

* Recommendation around thumbnails

* Update README.md

Co-authored-by: Pete Gadomski <[email protected]>

---------

Co-authored-by: Pete Gadomski <[email protected]>
jlaura pushed a commit to jlaura/projection that referenced this pull request Apr 3, 2023
* Add more examples, clarify/fix `proj:epsg` requirement stac-extensions#7, align repo with template

* Don't require proj:epsg as discussed in the STAC meeting

* Clarification

* Recommendation around thumbnails

* Update README.md

Co-authored-by: Pete Gadomski <[email protected]>

---------

Co-authored-by: Pete Gadomski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Best pratice: Provide proj:shape for thumbnails proj:epsg is marked as "required", but this only applies to items
5 participants