Skip to content

Don't use address if not allowed by country in AddressElement #11372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Aug 15, 2025

Summary

Don't use address if not allowed by country in AddressElement

Motivation

Improves AddressElement behavior to forgo usage of addresses from un-allowed countries.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │   2.1 MiB │   2.1 MiB │   0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.9 KiB │ 302.9 KiB │   0 B │   457 KiB │   457 KiB │  0 B 
   native │   7.9 MiB │   7.9 MiB │   0 B │  19.3 MiB │  19.3 MiB │  0 B 
    asset │   7.7 KiB │   7.7 KiB │   0 B │   7.5 KiB │   7.5 KiB │  0 B 
    other │  95.7 KiB │  95.7 KiB │ -11 B │ 183.5 KiB │ 183.5 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │  11.4 MiB │  11.4 MiB │ -11 B │  25.3 MiB │  25.3 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20683 │ 20683 │ 0 (+0 -0) 
   types │  6503 │  6503 │ 0 (+0 -0) 
 classes │  5267 │  5267 │ 0 (+0 -0) 
 methods │ 31506 │ 31506 │ 0 (+0 -0) 
  fields │ 18232 │ 18232 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3648 │ 3648 │  0
APK
    compressed    │   uncompressed   │                                           
──────────┬───────┼───────────┬──────┤                                           
 size     │ diff  │ size      │ diff │ path                                      
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 25.9 KiB │  -8 B │  64.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
 29.2 KiB │  -3 B │  64.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │  -1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │  +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 56.5 KiB │ -11 B │ 130.5 KiB │  0 B │ (total)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant