fix: avoid false-positive infinite loop error #16611
Draft
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks each effect's execution count and only advances the overall flush count if an inidivual effect was executed many times, hinting at a loop The count overall is kept in place because theoretically there could be other infinite loops happening with no user effect in the mix. Fixes part of #16548
🦋 Changeset detectedLatest commit: 6f0e43d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
dummdidumm
commented
Aug 13, 2025
| // lead to false-positives in the infinite loop detection. Therefore decrease | ||
| // the counter unless the individual effect has been executed many times, which | ||
| // indeed hints at an infinite loop. | ||
| if (execution_count < 1000) { |
There was a problem hiding this comment.
Does this additional measure make sense to prevent a case where effects are constantly created/destroyed because you're playing ping-pong with an if block appearing/disappearing? Dunno if even possible, but maybe?
Suggested change
| if (execution_count < 1000) { | |
| if (execution_count < 1000 && effect_execution_count.size < 10_000_000) { |
|
#16612 might be the better solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks each effect's execution count and only advances the overall flush count if an inidivual effect was executed many times, hinting at a loop
The count overall is kept in place because theoretically there could be other infinite loops happening with no user effect in the mix.
Fixes part of #16548
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint