Skip to content

cpp(BREAKING)!: support both global-level and messager-level load options #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

wenchy
Copy link
Member

@wenchy wenchy commented Aug 14, 2025

Related PRs

C++ compiler requirement

  • At least C++17

❗BREAKING CHANGE

We split the LoaderOptions into two kinds:

  1. LoaderOptions : global-level load options
  2. MessagerOptions: messager-level load options

So when setting options, there are some differences compared to before.

Compatibility resolution

patch_paths

options->patch_paths["PatchMergeConf"] = {"./path/to/file.json"};
// can be resolved to
auto mopts = std::make_shared<tableau::MessagerOptions>();
mopts->patch_paths = {"./path/to/file.json"};
options->messager_options["PatchMergeConf"] = mopts;

paths

options->paths["ItemConf"] = "./path/to/file.json";
// can be resolved to
auto mopts = std::make_shared<tableau::MessagerOptions>();
mopts->path = "./path/to/file.json";
options->messager_options["ItemConf"] = mopts;

@wenchy wenchy requested a review from Kybxd August 15, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants