editorial: correct AbstractModuleSource host invariants#77
Merged
Conversation
guybedford
added a commit
to guybedford/ecma262
that referenced
this pull request
Mar 24, 2026
guybedford
added a commit
to guybedford/ecma262
that referenced
this pull request
Mar 24, 2026
nicolo-ribaudo
approved these changes
Mar 24, 2026
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
I would also be interested in unifying the two definitions of source, updating this table to just say "a module source object", and defining a module source object as an object whose initial [[Prototype]] is an object whose initial [[Prototype]] is %AbstractModuleSource%.prototype.
legendecas
approved these changes
Mar 24, 2026
Collaborator
Author
|
@nicolo-ribaudo I've updated the module source object definition to match this now. |
guybedford
force-pushed
the
invariant-fix
branch
from
March 25, 2026 15:52
08f7403 to
ce73243
Compare
guybedford
added a commit
to guybedford/ecma262
that referenced
this pull request
Mar 25, 2026
guybedford
added a commit
to guybedford/ecma262
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a question recently brought up by @dminor in ensuring the following corrections to the stated host properties on module sources:
//cc @nicolo-ribaudo @legendecas