Skip to content

Conversation

gtache
Copy link
Contributor

@gtache gtache commented Jan 18, 2021

The new constructor is necessary if we want to use Pattern flags (like unicode support).
Compiling the pattern only once should also improve performance a bit.
(Also cleans up the file a bit)

By the way, the .editorConfig file specifies 4 spaces for indentation, but the file is indented with 2 spaces. Should it be reformatted?

Thanks for the toolkit by the way, I've used it quite a bit already for manipulating ods and odt, and it works (most of the time) like a charm!

@svanteschubert
Copy link
Contributor

Thanks for the patch and sorry for the delay in answering.

Indeed the format plugin is not working perfect, seems I need to add/commit changes before they are being considered to be formatted automatically (missing feature/bug).
To format manually you migth run by commandline:
mvn git-code-format:format-code -D"gcf.globPattern=/*"
or
mvn git-code-format:format-code -Dgcf.globPattern=
/*

After this manual format, your patch builds fine.
I will merge and fix it right away to save us some time!

Thanks again!
Svante

@svanteschubert svanteschubert merged commit 1e3d8cd into tdf:master Jan 29, 2021
@gtache
Copy link
Contributor Author

gtache commented Feb 1, 2021

No problem, thanks for the merge and for the command to format!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants