-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Added support for new commands in the MSO4, MSO4B, MSO5, MSO5B, MSO5LP, MSO6, MSO6B, and LPD6 models. #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for new commands in the MSO4, MSO4B, MSO5, MSO5B, MSO5LP, MSO6, MSO6B, and LPD6 models. #456
Conversation
… MSO5LP, MSO6, MSO6B, and LPD6 models.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 161 161
Lines 4744 4744
Branches 429 429
=========================================
Hits 4744 4744 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't make it through all the files, but there is a bunch of missing info in here.
…new_commands_added
…new_commands_added # Conflicts: # CHANGELOG.md
…new_commands_added
…new_commands_added
…new_commands_added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go through each file and make sure that none of the info pieces are being removed, there are still places where info has been removed
…new_commands_added
…new_commands_added
…new_commands_added
Breaking API Changes
|
Test Results (macos)
|
Test Results (ubuntu)
|
Test Results (windows)
|
Proposed changes
feat: Added support for new commands in the MSO4, MSO4B, MSO5, MSO5B, MSO5LP, MSO6, MSO6B, and LPD6 models.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>