Skip to content

Fairness weight override #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 86 commits into
base: main
Choose a base branch
from
Draft

Fairness weight override #8193

wants to merge 86 commits into from

Conversation

sivagirish81
Copy link
Contributor

What changed?

PR dependent on : #8135 [ Will merge after this PR is reviewed and merged ]

  • Pull fairnessWeightoverrides from persistence.

API PR : temporalio/api#626

Why?

  • FairnessWeights can be overriden via the UpdateTaskQueueConfig api for certain fairness keys and these configs need to be persisted and pulled from UserData when needed.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

N/A

sivagirish81 and others added 30 commits July 16, 2025 15:18
@sivagirish81
Attach rate limiter to config set via updateTaskQueueConfig api.
491bfe2
@sivagirish81
Fixed comments.
072c987
@sivagirish81
Merge branch 'main' into TQConfigAttachRateLimit
2dc4d91
@sivagirish81
Debug the task queue test
037a964
@sivagirish81
Fixed the functional test to check Api rate limit enforcement
f3509f7
@sivagirish81
Fix data race and flakyness of test
87f1c9e
@sivagirish81
Updated comments
b545a5f
@sivagirish81
Merge branch 'main' into TQConfigAttachRateLimit
8cae0be
@sivagirish81
Fixed unit test
bc86951
@sivagirish81
Increased buffer & drainTimeout + changed test behaviour to avoid eff…
136bf94 
…ect of burst
@sivagirish81
Fix panic in test execution
7086759
@sivagirish81
Removed unnecessary tests and incorporated review comments
ea32e41
@sivagirish81
Merge branch 'main' into TQConfigAttachRateLimit
01cda4b
@sivagirish81
Fixed unit test and naming convention for locked functions.
fff463b
@sivagirish81
Merge pull request #1 from sivagirish81/temp-push
298cd42 
Fixed unit test and naming convention for locked functions.
@sivagirish81
Merge branch 'main' into TQConfigAttachRateLimit
f664a21
@sivagirish81
Addressed PR Comments
8484292
@sivagirish81
Merge branch 'main' into TQConfigAttachRateLimit
3fda810
@sivagirish81
Addressed comments
c3e96f1
@sivagirish81
Merge branch 'main' into TQConfigAttachRateLimit
fd4fe29
@sivagirish81
Moved Fairness RateLimits -> Task Queue Partition Manager lvl
d8a804f
@sivagirish81
Change order of rateLimitManager update on userDataChange
2968640
@sivagirish81
Fixed test issues
8e45446
@sivagirish81
Moved SimpleRateLimiter worker rps injection to taskqueuepartitionmgr…
f8a0e62 
… level
@sivagirish81
Locked consumeTokens + fixed lint issues
bef9a07
@sivagirish81
Fixed the locking in the tests
1a008c4
@sivagirish81
Fixed TestSyncMatch
9af527e
@sivagirish81
Changed test to avoid flakiness
7936019
@sivagirish81
Changed default value of effectiveRPS to inf
c7ae4b5
@sivagirish81
Merge branch 'main' into TQConfigAttachRateLimit
36d84b7
sivagirish81 and others added 25 commits August 7, 2025 17:42
@sivagirish81
Merge branch 'main' into TQFairnessRateLimit
e6ceb1e
@sivagirish81
Debug : Force Load Data from persistence before polling
2f71380
@sivagirish81
Fixed buffer to avoid flakiness
7fcc775
@sivagirish81
Fixed read partitions to get tracked for changes to rate limit
5ac69f1
@sivagirish81
Merge branch 'main' into TQFairnessRateLimit
9a32cdc
@sivagirish81
Removed subscribtion for numReadPartition + fixed partitionCount logic
a327673
@sivagirish81
Added todo to revert dynamic config for partitions
e6881f9
@sivagirish81
Fixed getEffectiveRPS
720e2dd
@sivagirish81
Fixed fairnessKeyRateLimitDEfault to per-partition
3c1823c
@sivagirish81
Fixed test flakyness
1ae7423
@sivagirish81
Debug task_queue_test on CI
7548dc7
@sivagirish81
Added fairness rate limit tests + debug logs
ac58f09
@sivagirish81
added verbose flag for debugging
c31b12b
@sivagirish81
Added -test.v flag for debugging
89b0ad3
@sivagirish81
Fixed non unique workflow id's
adae7c8
@sivagirish81
Testing commit
e23ea77
@sivagirish81
test
7422231
@sivagirish81
Reverted makefile changes
a901d89
@sivagirish81
Refactored tests + reverted debug statements
603a413
@sivagirish81
Merge branch 'main' into TQFairnessRateLimit
8ceb110
@sivagirish81
Test refactor
44e41fe
@sivagirish81
Matching fairness weight override Implementation
cfce2bb
@sivagirish81
temp
47e08a9
@sivagirish81
Merge main
4aa0195
@sivagirish81
Merge branch 'main' into FairnessWeightOverride
1b54c42
@sivagirish81 sivagirish81 force-pushed the FairnessWeightOverride branch 2 times, most recently from 1009b37 to 814a53a Compare August 14, 2025 01:00
@sivagirish81 sivagirish81 force-pushed the FairnessWeightOverride branch from 814a53a to 40355cb Compare August 15, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sivagirish81