feat(CLI): Support per-user config #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ce Gao <[email protected]>
VoVAllen
approved these changes
Apr 25, 2022
| @@ -64,6 +66,11 @@ func (b generalBuilder) GPUEnabled() bool { | |||
|
|
|||
| func (b generalBuilder) Build(ctx context.Context) error { | |||
| interpreter := starlark.NewInterpreter() | |||
| // Evaluate config first. | |||
| if _, err := interpreter.ExecFile(b.configFilePath); err != nil { | |||
There was a problem hiding this comment.
So ~/.midi/config.MIDI will be executed after the midi file in the project?
There was a problem hiding this comment.
The behavior now is to eval the config first, then the build.MIDI. I am not sure if it is expected, actually
| @@ -64,6 +66,11 @@ func (b generalBuilder) GPUEnabled() bool { | |||
|
|
|||
| func (b generalBuilder) Build(ctx context.Context) error { | |||
| interpreter := starlark.NewInterpreter() | |||
| // Evaluate config first. | |||
| if _, err := interpreter.ExecFile(b.configFilePath); err != nil { | |||
There was a problem hiding this comment.
And where's the default file name?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A config file
~/.midi/config.MIDIis introducedYou can define some MIDI statements and it works for all environments
Fix #22
Signed-off-by: Ce Gao [email protected]